hertog/godot-module-template
Template
2
1
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Better warnings when resources can't be saved. Fixes #26531

Browse source
This commit is contained in:
Juan Linietsky 2019-03-04 11:06:15 -03:00
parent e23a192482
commit e653c79ef7
4 changed files with 45 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

18
editor/editor_node.cpp
View file

@ -619,7 +619,11 @@ void EditorNode::save_resource_in_path(const Ref<Resource> &p_resource, const St
Error err = ResourceSaver::save(path, p_resource, flg | ResourceSaver::FLAG_REPLACE_SUBRESOURCE_PATHS);
if (err != OK) {
show_accept(TTR("Error saving resource!"), TTR("OK"));
if (ResourceLoader::is_imported(p_resource->get_path())) {
show_accept(TTR("Imported resources can't be saved."), TTR("OK"));
} else {
show_accept(TTR("Error saving resource!"), TTR("OK"));
}
return;
}
@ -639,6 +643,18 @@ void EditorNode::save_resource(const Ref<Resource> &p_resource) {
void EditorNode::save_resource_as(const Ref<Resource> &p_resource, const String &p_at_path) {
{
String path = p_resource->get_path();
int srpos = path.find("::");
if (srpos != -1) {
String base = path.substr(0, srpos);
if (!get_edited_scene() || get_edited_scene()->get_filename() != base) {
show_warning(TTR("This resource can't be saved because it does not belong to the edited scene. Make it unique first."));
return;
}
}
}
file->set_mode(EditorFileDialog::MODE_SAVE_FILE);
saving_resource = p_resource;