From 360fb0ffa80d807ae0334a9f4f1c9c4833a383b1 Mon Sep 17 00:00:00 2001 From: PouleyKetchoupp Date: Sun, 11 Aug 2019 12:17:18 +0200 Subject: [PATCH 1/2] Fixed link errors when building in debug with option module_regex_enabled=no --- main/tests/test_string.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/main/tests/test_string.cpp b/main/tests/test_string.cpp index ab5fb64252..7a41880645 100644 --- a/main/tests/test_string.cpp +++ b/main/tests/test_string.cpp @@ -432,6 +432,10 @@ bool test_26() { OS::get_singleton()->print("\n\nTest 26: RegEx substitution\n"); +#ifndef MODULE_REGEX_ENABLED + OS::get_singleton()->print("\tRegEx module disabled, can't run test."); + return false; +#else String s = "Double all the vowels."; OS::get_singleton()->print("\tString: %ls\n", s.c_str()); @@ -443,6 +447,7 @@ bool test_26() { OS::get_singleton()->print("\tResult: %ls\n", s.c_str()); return (s == "Doouublee aall thee vooweels."); +#endif } struct test_27_data { From a1a0fb1467f72c652cacbc77fa7efdb241b8e454 Mon Sep 17 00:00:00 2001 From: PouleyKetchoupp Date: Sun, 11 Aug 2019 19:07:59 +0200 Subject: [PATCH 2/2] Prevent editor compilation with regex module disabled, which is not supported --- SConstruct | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/SConstruct b/SConstruct index aa5e3a98c8..128c5b0e92 100644 --- a/SConstruct +++ b/SConstruct @@ -484,6 +484,13 @@ if selected_platform in platform_list: if env['minizip']: env.Append(CPPDEFINES=['MINIZIP_ENABLED']) + editor_module_list = ['regex'] + for x in editor_module_list: + if not env['module_' + x + '_enabled']: + if env['tools']: + print("Build option 'module_" + x + "_enabled=no' cannot be used with 'tools=yes' (editor), only with 'tools=no' (export template).") + sys.exit(255) + if not env['verbose']: methods.no_verbose(sys, env)