Merge pull request #105942 from PhairZ/isthisoptimization-evenworthit

Make `script_class_get_icon_path()` return any value when `r_valid` is passed.
This commit is contained in:
Thaddeus Crews 2025-05-13 16:22:19 -05:00
commit 74b466ac29
No known key found for this signature in database
GPG key ID: 8C6E5FEB5FC03CCC

View file

@ -1024,10 +1024,12 @@ String EditorData::script_class_get_icon_path(const String &p_class, bool *r_val
}
HashMap<StringName, String>::ConstIterator E = _script_class_icon_paths.find(current);
if ((bool)E) {
if (r_valid && !E->value.is_empty()) {
*r_valid = true;
if (r_valid) {
*r_valid = !E->value.is_empty();
return E->value;
} else if (!E->value.is_empty()) {
return E->value;
}
return E->value;
}
current = ScriptServer::get_global_class_base(current);
}