hertog/godot-module-template
Template
2
1
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

GDScript: fix regression when checking for virtual function implementation.

Browse source 
Unfortunately it appears the virtual function checks in #77324 are not
trustworthy at runtime, because objects can have scripts attached, but
this information is not always available at compile-time. These checks
need to be removed.

The rest of the PR is still useful, making all method flags available to
the analyzer, so a full revert isn't necessary/desirable.

This reopens #76938, which will need another solution.
This commit is contained in:
ocean (they/them) 2023-06-21 15:13:45 -04:00
parent 28a60b3de0
commit 6c28b8edd3
9 changed files with 0 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

11
modules/gdscript/tests/scripts/analyzer/features/virtual_method_implemented.gd
View file

@ -1,11 +0,0 @@
class TestOne:
func _get_property_list():
return {}
class TestTwo extends TestOne:
func _init():
var _x = _get_property_list()
func test():
var x = TestTwo.new()
var _x = x._get_property_list()