hertog/godot-module-template
Template
2
1
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use C++ iterators for Lists in many situations

Browse source
This commit is contained in:
Aaron Franke 2021-07-15 23:45:57 -04:00
parent b918c4c3ce
commit 4e6efd1b07
No known key found for this signature in database
GPG key ID: 40A1750B977E56BF
218 changed files with 2755 additions and 3004 deletions
Download patch file Download diff file Expand all files Collapse all files

20
core/object/undo_redo.cpp
View file

@ -39,12 +39,12 @@ void UndoRedo::_discard_redo() {
}
for (int i = current_action + 1; i < actions.size(); i++) {
for (List<Operation>::Element *E = actions.write[i].do_ops.front(); E; E = E->next()) {
if (E->get().type == Operation::TYPE_REFERENCE) {
if (E->get().ref.is_valid()) {
E->get().ref.unref();
for (Operation &E : actions.write[i].do_ops) {
if (E.type == Operation::TYPE_REFERENCE) {
if (E.ref.is_valid()) {
E.ref.unref();
} else {
Object *obj = ObjectDB::get_instance(E->get().object);
Object *obj = ObjectDB::get_instance(E.object);
if (obj) {
memdelete(obj);
}
@ -244,12 +244,12 @@ void UndoRedo::_pop_history_tail() {
return;
}
for (List<Operation>::Element *E = actions.write[0].undo_ops.front(); E; E = E->next()) {
if (E->get().type == Operation::TYPE_REFERENCE) {
if (E->get().ref.is_valid()) {
E->get().ref.unref();
for (Operation &E : actions.write[0].undo_ops) {
if (E.type == Operation::TYPE_REFERENCE) {
if (E.ref.is_valid()) {
E.ref.unref();
} else {
Object *obj = ObjectDB::get_instance(E->get().object);
Object *obj = ObjectDB::get_instance(E.object);
if (obj) {
memdelete(obj);
}