hertog/godot-module-template
Template
2
1
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

GDScript: Replace ptrcalls on MethodBind to validated calls

Browse source 
This improves the performance of typed calls to engine methods when the
argument types are exact.

Using validated calls delegate more of the work the core instead of
doing argument unpacking in the VM. It also does not need different
instructions for each return type, simplifying the code.
This commit is contained in:
George Marques 2023-07-25 12:42:07 -03:00
parent fba341ce44
commit 4a7d49a89a
No known key found for this signature in database
GPG key ID: 046BD46A3201E43D
8 changed files with 213 additions and 497 deletions
Download patch file Download diff file Expand all files Collapse all files

6
modules/gdscript/tests/scripts/runtime/features/standalone-calls-do-not-write-to-nil.gd
View file

@ -7,7 +7,7 @@ func test():
test_builtin_call_validated(Vector2.UP, false)
test_object_call(RefCounted.new(), false)
test_object_call_method_bind(Resource.new(), false)
test_object_call_ptrcall(RefCounted.new(), false)
test_object_call_method_bind_validated(RefCounted.new(), false)
print("end")
@ -40,7 +40,7 @@ func test_object_call_method_bind(v: Resource, f):
v.duplicate() # Native type method call with MethodBind.
assert(not f) # Test unary operator reading from `nil`.
func test_object_call_ptrcall(v: RefCounted, f):
func test_object_call_method_bind_validated(v: RefCounted, f):
@warning_ignore("return_value_discarded")
v.get_reference_count() # Native type method call with ptrcall.
v.get_reference_count() # Native type method call with validated MethodBind.
assert(not f) # Test unary operator reading from `nil`.