From 8b34d5d60846097e053b3f18cbee86d62df6bf22 Mon Sep 17 00:00:00 2001 From: passivestar <60579014+passivestar@users.noreply.github.com> Date: Fri, 20 Feb 2026 21:01:41 +0400 Subject: [PATCH] Tweaks to EditorHelp separator colors --- editor/doc/editor_help.cpp | 4 ++-- editor/themes/theme_classic.cpp | 2 ++ editor/themes/theme_modern.cpp | 2 ++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/editor/doc/editor_help.cpp b/editor/doc/editor_help.cpp index a2ed9d83d0..07f74f455a 100644 --- a/editor/doc/editor_help.cpp +++ b/editor/doc/editor_help.cpp @@ -218,8 +218,8 @@ void EditorHelp::_update_theme_item_cache() { theme_cache.qualifier_color = get_theme_color(SNAME("qualifier_color"), SNAME("EditorHelp")); theme_cache.type_color = get_theme_color(SNAME("type_color"), SNAME("EditorHelp")); theme_cache.override_color = get_theme_color(SNAME("override_color"), SNAME("EditorHelp")); - theme_cache.primary_hr_color = Color(theme_cache.title_color, 0.25); - theme_cache.secondary_hr_color = Color(theme_cache.comment_color, 0.25); + theme_cache.primary_hr_color = get_theme_color(SNAME("primary_hr_color"), SNAME("EditorHelp")); + theme_cache.secondary_hr_color = get_theme_color(SNAME("secondary_hr_color"), SNAME("EditorHelp")); theme_cache.doc_font = get_theme_font(SNAME("doc"), EditorStringName(EditorFonts)); theme_cache.doc_bold_font = get_theme_font(SNAME("doc_bold"), EditorStringName(EditorFonts)); diff --git a/editor/themes/theme_classic.cpp b/editor/themes/theme_classic.cpp index 5d70852f9a..cc72299e79 100644 --- a/editor/themes/theme_classic.cpp +++ b/editor/themes/theme_classic.cpp @@ -2330,6 +2330,8 @@ void ThemeClassic::populate_editor_styles(const Ref &p_theme, Edito p_theme->set_color("code_bg_color", "EditorHelp", p_config.dark_color_3); p_theme->set_color("kbd_bg_color", "EditorHelp", p_config.dark_color_1); p_theme->set_color("param_bg_color", "EditorHelp", p_config.dark_color_1); + p_theme->set_color("primary_hr_color", "EditorHelp", p_config.base_color.lerp(p_config.mono_color_font, p_config.dark_theme ? 0.14 : 0.24)); + p_theme->set_color("secondary_hr_color", "EditorHelp", p_config.base_color.lerp(p_config.mono_color_font, p_config.dark_theme ? 0.12 : 0.22)); p_theme->set_constant(SceneStringName(line_separation), "EditorHelp", Math::round(6 * EDSCALE)); p_theme->set_constant(SceneStringName(paragraph_separation), "EditorHelp", Math::round(10 * EDSCALE)); p_theme->set_constant("table_h_separation", "EditorHelp", 16 * EDSCALE); diff --git a/editor/themes/theme_modern.cpp b/editor/themes/theme_modern.cpp index e3496c28bb..a92c7205d6 100644 --- a/editor/themes/theme_modern.cpp +++ b/editor/themes/theme_modern.cpp @@ -2644,6 +2644,8 @@ void ThemeModern::populate_editor_styles(const Ref &p_theme, Editor p_theme->set_color("code_bg_color", "EditorHelp", _get_base_color(p_config, 1.6, 0.8)); p_theme->set_color("kbd_bg_color", "EditorHelp", p_config.dark_color_1); p_theme->set_color("param_bg_color", "EditorHelp", p_config.dark_color_1); + p_theme->set_color("primary_hr_color", "EditorHelp", p_config.base_color.lerp(p_config.mono_color_font, p_config.dark_theme ? 0.14 : 0.24)); + p_theme->set_color("secondary_hr_color", "EditorHelp", p_config.base_color.lerp(p_config.mono_color_font, p_config.dark_theme ? 0.12 : 0.22)); p_theme->set_constant(SceneStringName(line_separation), "EditorHelp", Math::round(6 * EDSCALE)); p_theme->set_constant(SceneStringName(paragraph_separation), "EditorHelp", Math::round(10 * EDSCALE)); p_theme->set_constant("table_h_separation", "EditorHelp", 16 * EDSCALE);