hertog/godot-module-template
Template
2
1
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #69562 from timothyqiu/tileset-editor

Browse source 
Fix heap-use-after-free when exiting editor after editing TileSet
This commit is contained in:
Rémi Verschelde 2022-12-05 00:05:17 +01:00
commit 12775703ba
No known key found for this signature in database
GPG key ID: C3336907360768E1
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
editor/plugins/tiles/tile_set_atlas_source_editor.cpp
View file

@ -2345,6 +2345,15 @@ void TileSetAtlasSourceEditor::_notification(int p_what) {
tile_set_changed_needs_update = false;
}
} break;
case NOTIFICATION_EXIT_TREE: {
for (KeyValue<String, TileDataEditor *> &E : tile_data_editors) {
Control *toolbar = E.value->get_toolbar();
if (toolbar->get_parent() == tool_settings_tile_data_toolbar_container) {
tool_settings_tile_data_toolbar_container->remove_child(toolbar);
}
}
} break;
}
}