hertog/godot-module-template
Template
2
1
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #38743 from arrowinaknee/node-config-warnings

Browse source 
Update all get_configuration_warning() to retrieve warnings from the parent
This commit is contained in:
Rémi Verschelde 2020-10-01 14:03:29 +02:00 • committed by GitHub
commit 12091b39d2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
40 changed files with 284 additions and 114 deletions
Download patch file Download diff file Expand all files Collapse all files

16
scene/3d/world_environment.cpp
View file

@ -110,22 +110,30 @@ Ref<CameraEffects> WorldEnvironment::get_camera_effects() const {
}
String WorldEnvironment::get_configuration_warning() const {
String warning = Node::get_configuration_warning();
if (!environment.is_valid()) {
return TTR("WorldEnvironment requires its \"Environment\" property to contain an Environment to have a visible effect.");
if (!warning.empty()) {
warning += "\n\n";
}
warning += TTR("WorldEnvironment requires its \"Environment\" property to contain an Environment to have a visible effect.");
}
if (!is_inside_tree()) {
return String();
return warning;
}
List<Node *> nodes;
get_tree()->get_nodes_in_group("_world_environment_" + itos(get_viewport()->find_world_3d()->get_scenario().get_id()), &nodes);
if (nodes.size() > 1) {
return TTR("Only one WorldEnvironment is allowed per scene (or set of instanced scenes).");
if (!warning.empty()) {
warning += "\n\n";
}
warning += TTR("Only one WorldEnvironment is allowed per scene (or set of instanced scenes).");
}
return String();
return warning;
}
void WorldEnvironment::_bind_methods() {