hertog/godot-module-template
Template
2
1
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Codestyle: Don't use auto where not warranted

Browse source 
We allow using auto for lambdas or complex macros where a return type
may change based on the parameters. But where the type is clear, we
should be explicit.

Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
This commit is contained in:
Rémi Verschelde 2023-09-07 14:39:57 +02:00
parent d6d8cb1a17
commit 11518665b7
No known key found for this signature in database
GPG key ID: C3336907360768E1
6 changed files with 16 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/core/variant/test_dictionary.h
View file

@ -90,7 +90,7 @@ TEST_CASE("[Dictionary] Assignment using bracket notation ([])") {
CHECK(int(map[false]) == 128);
// Ensure read-only maps aren't modified by non-existing keys.
const auto length = map.size();
const int length = map.size();
map.make_read_only();
CHECK(int(map["This key does not exist"].get_type()) == Variant::NIL);
CHECK(map.size() == length);

2
tests/scene/test_arraymesh.h
View file

@ -195,7 +195,7 @@ TEST_CASE("[SceneTree][ArrayMesh] Surface metadata tests.") {
}
SUBCASE("Returns correct format for the mesh") {
auto format = RS::ARRAY_FORMAT_BLEND_SHAPE_MASK | RS::ARRAY_FORMAT_TEX_UV | RS::ARRAY_FORMAT_INDEX;
int format = RS::ARRAY_FORMAT_BLEND_SHAPE_MASK | RS::ARRAY_FORMAT_TEX_UV | RS::ARRAY_FORMAT_INDEX;
CHECK((mesh->surface_get_format(0) & format) != 0);
CHECK((mesh->surface_get_format(1) & format) != 0);
}

4
tests/servers/rendering/test_shader_preprocessor.h
View file

@ -66,7 +66,7 @@ String remove_spaces(String &p_str) {
for (int n = 0; n < p_str.size(); n++) {
// These test cases only use ASCII.
auto c = static_cast<unsigned char>(p_str[n]);
unsigned char c = static_cast<unsigned char>(p_str[n]);
if (std::isblank(c)) {
has_removed = true;
} else {
@ -92,7 +92,7 @@ String remove_spaces(String &p_str) {
String compact_spaces(String &p_str) {
Vector<String> lines = p_str.split("\n", false);
erase_all_empty(lines);
for (auto &line : lines) {
for (String &line : lines) {
line = remove_spaces(line);
}
return String("\n").join(lines);