From ed0efc4791088dfd0608476ef9d2067d46e26c3c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C4=81vels=20Nadto=C4=8Dajevs?= <7645683+bruvzg@users.noreply.github.com> Date: Sun, 20 Jul 2025 21:42:20 +0200 Subject: [PATCH] Fix support data loading with system ICU --- modules/text_server_adv/SCsub | 3 +++ modules/text_server_adv/text_server_adv.cpp | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/modules/text_server_adv/SCsub b/modules/text_server_adv/SCsub index 240ccd9a0e..1167fbc187 100644 --- a/modules/text_server_adv/SCsub +++ b/modules/text_server_adv/SCsub @@ -25,6 +25,9 @@ if "svg" in env.module_list: # Enable ThorVG static object linking. env_text_server_adv.Append(CPPDEFINES=["TVG_STATIC"]) +if env["builtin_icu4c"]: + env_text_server_adv.Append(CPPDEFINES=["HAVE_ICU_BUILTIN"]) + if env["builtin_harfbuzz"]: env_harfbuzz = env_modules.Clone() env_harfbuzz.disable_warnings() diff --git a/modules/text_server_adv/text_server_adv.cpp b/modules/text_server_adv/text_server_adv.cpp index 69866bbf53..06f93a135a 100644 --- a/modules/text_server_adv/text_server_adv.cpp +++ b/modules/text_server_adv/text_server_adv.cpp @@ -434,7 +434,7 @@ bool TextServerAdvanced::_has(const RID &p_rid) { bool TextServerAdvanced::_load_support_data(const String &p_filename) { _THREAD_SAFE_METHOD_ -#ifdef ICU_STATIC_DATA +#if defined(ICU_STATIC_DATA) || !defined(HAVE_ICU_BUILTIN) if (!icu_data_loaded) { UErrorCode err = U_ZERO_ERROR; u_init(&err); // Do not check for errors, since we only load part of the data.