Sara/behaviour-tree-test
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

Merge pull request #102993 from bruvzg/fix_cb_win_erase

Browse source 
Prevent pending input event callbacks from erasing the window in the middle of a loop.
This commit is contained in:
Thaddeus Crews 2025-02-18 20:47:53 -06:00
commit e91493fb7b
No known key found for this signature in database
GPG key ID: 62181B86FE9E5D84
3 changed files with 20 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
platform/windows/display_server_windows.cpp
View file

@ -4253,13 +4253,17 @@ void DisplayServerWindows::_dispatch_input_event(const Ref<InputEvent> &p_event)
}
}
} else {
// Send to all windows.
for (const KeyValue<WindowID, WindowData> &E : windows) {
const Callable callable = E.value.input_event_callback;
// Send to all windows. Copy all pending callbacks, since callback can erase window.
Vector<Callable> cbs;
for (KeyValue<WindowID, WindowData> &E : windows) {
Callable callable = E.value.input_event_callback;
if (callable.is_valid()) {
callable.call(p_event);
cbs.push_back(callable);
}
}
for (const Callable &cb : cbs) {
cb.call(p_event);
}
}
in_dispatch_input_event = false;