Sara/behaviour-tree-test
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

Merge pull request #99133 from dsnopek/gdextension-reloadable-when-not-createable

Browse source 
GDExtension: Check if class without recreate callback is creatable, before marking whole extension as unreloadable
This commit is contained in:
Thaddeus Crews 2025-06-09 12:31:36 -05:00
commit c10c656ea7
No known key found for this signature in database
GPG key ID: 8C6E5FEB5FC03CCC
1 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
core/extension/gdextension.cpp
View file

@ -410,8 +410,16 @@ void GDExtension::_register_extension_class_internal(GDExtensionClassLibraryPtr
}
if (self->reloadable && p_extension_funcs->recreate_instance_func == nullptr) {
ERR_PRINT(vformat("Extension marked as reloadable, but attempted to register class '%s' which doesn't support reloading. Perhaps your language binding don't support it? Reloading disabled for this extension.", class_name));
self->reloadable = false;
bool can_create_class = (bool)p_extension_funcs->create_instance_func;
#ifndef DISABLE_DEPRECATED
if (!can_create_class && p_deprecated_funcs) {
can_create_class = (bool)p_deprecated_funcs->create_instance_func;
}
#endif
if (can_create_class) {
ERR_PRINT(vformat("Extension marked as reloadable, but attempted to register class '%s' which doesn't support reloading. Perhaps your language binding don't support it? Reloading disabled for this extension.", class_name));
self->reloadable = false;
}
}
extension->gdextension.library = self;