Sara/behaviour-tree-test
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

Decouple RenderingServer from ServersDebugger

Browse source 
This one doesn't seem to have much impact on incremental rebuild time
after a change in `rendering_server.h`, but might still be worth it to
prevent future heavier coupling.
This commit is contained in:
Rémi Verschelde 2026-02-18 20:42:58 +01:00
parent f5a290ac46
commit b144637ae1
No known key found for this signature in database
GPG key ID: C3336907360768E1
6 changed files with 67 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

5
servers/debugger/servers_debugger.cpp
View file

@ -36,6 +36,7 @@
#include "core/io/resource_loader.h"
#include "core/object/script_language.h"
#include "servers/display/display_server.h"
#include "servers/rendering/rendering_server.h"
#define CHECK_SIZE(arr, expected, what) ERR_FAIL_COND_V_MSG((uint32_t)arr.size() < (uint32_t)(expected), false, String("Malformed ") + what + " message from script debugger, message too short. Expected size: " + itos(expected) + ", actual size: " + itos(arr.size()))
#define CHECK_END(arr, expected, what) ERR_FAIL_COND_V_MSG((uint32_t)arr.size() > (uint32_t)expected, false, String("Malformed ") + what + " message from script debugger, message too long. Expected size: " + itos(expected) + ", actual size: " + itos(arr.size()))
@ -170,7 +171,7 @@ bool ServersDebugger::VisualProfilerFrame::deserialize(const Array &p_arr) {
CHECK_SIZE(p_arr, size, "VisualProfilerFrame");
int idx = 2;
areas.resize(size / 3);
RS::FrameProfileArea *w = areas.ptrw();
RenderingServerTypes::FrameProfileArea *w = areas.ptrw();
for (int i = 0; i < size / 3; i++) {
w[i].name = p_arr[idx];
w[i].cpu_msec = p_arr[idx + 1];
@ -371,7 +372,7 @@ public:
void add(const Array &p_data) {}
void tick(double p_frame_time, double p_process_time, double p_physics_time, double p_physics_frame_time) {
Vector<RS::FrameProfileArea> profile_areas = RS::get_singleton()->get_frame_profile();
Vector<RenderingServerTypes::FrameProfileArea> profile_areas = RS::get_singleton()->get_frame_profile();
ServersDebugger::VisualProfilerFrame frame;
if (!profile_areas.size()) {
return;