Sara/behaviour-tree-test
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

Use const ref parameters in the Web modules

Browse source
This commit is contained in:
Aaron Franke 2025-09-27 10:46:27 -07:00
parent b4472f4670
commit ac2e01684c
No known key found for this signature in database
GPG key ID: 40A1750B977E56BF
19 changed files with 80 additions and 80 deletions
Download patch file Download diff file Expand all files Collapse all files

8
modules/webxr/webxr_interface.h
View file

@ -57,13 +57,13 @@ public:
};
virtual void is_session_supported(const String &p_session_mode) = 0;
virtual void set_session_mode(String p_session_mode) = 0;
virtual void set_session_mode(const String &p_session_mode) = 0;
virtual String get_session_mode() const = 0;
virtual void set_required_features(String p_required_features) = 0;
virtual void set_required_features(const String &p_required_features) = 0;
virtual String get_required_features() const = 0;
virtual void set_optional_features(String p_optional_features) = 0;
virtual void set_optional_features(const String &p_optional_features) = 0;
virtual String get_optional_features() const = 0;
virtual void set_requested_reference_space_types(String p_requested_reference_space_types) = 0;
virtual void set_requested_reference_space_types(const String &p_requested_reference_space_types) = 0;
virtual String get_requested_reference_space_types() const = 0;
virtual String get_reference_space_type() const = 0;
virtual String get_enabled_features() const = 0;

10
modules/webxr/webxr_interface_js.cpp
View file

@ -121,7 +121,7 @@ void WebXRInterfaceJS::is_session_supported(const String &p_session_mode) {
godot_webxr_is_session_supported(p_session_mode.utf8().get_data(), &_emwebxr_on_session_supported);
}
void WebXRInterfaceJS::set_session_mode(String p_session_mode) {
void WebXRInterfaceJS::set_session_mode(const String &p_session_mode) {
session_mode = p_session_mode;
}
@ -129,7 +129,7 @@ String WebXRInterfaceJS::get_session_mode() const {
return session_mode;
}
void WebXRInterfaceJS::set_required_features(String p_required_features) {
void WebXRInterfaceJS::set_required_features(const String &p_required_features) {
required_features = p_required_features;
}
@ -137,7 +137,7 @@ String WebXRInterfaceJS::get_required_features() const {
return required_features;
}
void WebXRInterfaceJS::set_optional_features(String p_optional_features) {
void WebXRInterfaceJS::set_optional_features(const String &p_optional_features) {
optional_features = p_optional_features;
}
@ -145,7 +145,7 @@ String WebXRInterfaceJS::get_optional_features() const {
return optional_features;
}
void WebXRInterfaceJS::set_requested_reference_space_types(String p_requested_reference_space_types) {
void WebXRInterfaceJS::set_requested_reference_space_types(const String &p_requested_reference_space_types) {
requested_reference_space_types = p_requested_reference_space_types;
}
@ -251,7 +251,7 @@ bool WebXRInterfaceJS::set_environment_blend_mode(EnvironmentBlendMode p_new_env
return false;
}
void WebXRInterfaceJS::_set_environment_blend_mode(String p_blend_mode_string) {
void WebXRInterfaceJS::_set_environment_blend_mode(const String &p_blend_mode_string) {
if (p_blend_mode_string == "opaque") {
environment_blend_mode = XRInterface::XR_ENV_BLEND_MODE_OPAQUE;
} else if (p_blend_mode_string == "additive") {

14
modules/webxr/webxr_interface_js.h
View file

@ -94,13 +94,13 @@ private:
public:
virtual void is_session_supported(const String &p_session_mode) override;
virtual void set_session_mode(String p_session_mode) override;
virtual void set_session_mode(const String &p_session_mode) override;
virtual String get_session_mode() const override;
virtual void set_required_features(String p_required_features) override;
virtual void set_required_features(const String &p_required_features) override;
virtual String get_required_features() const override;
virtual void set_optional_features(String p_optional_features) override;
virtual void set_optional_features(const String &p_optional_features) override;
virtual String get_optional_features() const override;
virtual void set_requested_reference_space_types(String p_requested_reference_space_types) override;
virtual void set_requested_reference_space_types(const String &p_requested_reference_space_types) override;
virtual String get_requested_reference_space_types() const override;
virtual String get_reference_space_type() const override;
virtual String get_enabled_features() const override;
@ -142,9 +142,9 @@ public:
void _on_input_event(int p_event_type, int p_input_source_id);
// Internal setters used by callbacks from Emscripten.
inline void _set_reference_space_type(String p_reference_space_type) { reference_space_type = p_reference_space_type; }
inline void _set_enabled_features(String p_enabled_features) { enabled_features = p_enabled_features; }
void _set_environment_blend_mode(String p_blend_mode_string);
inline void _set_reference_space_type(const String &p_reference_space_type) { reference_space_type = p_reference_space_type; }
inline void _set_enabled_features(const String &p_enabled_features) { enabled_features = p_enabled_features; }
void _set_environment_blend_mode(const String &p_blend_mode_string);
WebXRInterfaceJS();
~WebXRInterfaceJS();