Sara/behaviour-tree-test
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

GDScript: Fix temp values being written without proper clear

Browse source 
Temporary values in the stack were not being properly cleared when the
return value of calls were discarded, which can cause memory issues
especially for reference types like PackedByteArray.
This commit is contained in:
George Marques 2023-01-11 14:24:23 -03:00
parent 2ac2db8de5
commit 66fda2aeea
No known key found for this signature in database
GPG key ID: 046BD46A3201E43D
4 changed files with 61 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

17
modules/gdscript/tests/scripts/runtime/features/does_not_override_temp_values.gd Normal file
View file

@ -0,0 +1,17 @@
# https://github.com/godotengine/godot/issues/71177
func test():
builtin_method()
builtin_method_static()
print("done")
func builtin_method():
var pba := PackedByteArray()
@warning_ignore(return_value_discarded)
pba.resize(1) # Built-in validated.
func builtin_method_static():
var _pba := PackedByteArray()
@warning_ignore(return_value_discarded)
Vector2.from_angle(PI) # Static built-in validated.

2
modules/gdscript/tests/scripts/runtime/features/does_not_override_temp_values.out Normal file
View file

@ -0,0 +1,2 @@
GDTEST_OK
done