Sara/behaviour-tree-test
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

Merge pull request #104689 from Delsin-Yu/csharp-getset-alloc-perf

Browse source 
[.Net] Avoid unnecessary StringName allocations on not implemented virtual _Get and _Set method call
This commit is contained in:
Thaddeus Crews 2025-04-14 19:39:53 -05:00
commit 561dc6ced6
No known key found for this signature in database
GPG key ID: 8C6E5FEB5FC03CCC
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
modules/mono/glue/GodotSharp/GodotSharp/Core/Bridge/CSharpInstanceBridge.cs
View file

@ -59,6 +59,11 @@ namespace Godot.Bridge
return godot_bool.True;
}
if (!godotObject.HasGodotClassMethod(GodotObject.MethodName._Set.NativeValue.DangerousSelfRef))
{
return godot_bool.False;
}
var nameManaged = StringName.CreateTakingOwnershipOfDisposableValue(
NativeFuncs.godotsharp_string_name_new_copy(CustomUnsafe.AsRef(name)));
@ -107,6 +112,11 @@ namespace Godot.Bridge
return godot_bool.True;
}
if (!godotObject.HasGodotClassMethod(GodotObject.MethodName._Get.NativeValue.DangerousSelfRef))
{
return godot_bool.False;
}
var nameManaged = StringName.CreateTakingOwnershipOfDisposableValue(
NativeFuncs.godotsharp_string_name_new_copy(CustomUnsafe.AsRef(name)));