Sara/behaviour-tree-test
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

Merge pull request #115646 from Ivorforce/list-explicit-copy

Browse source 
Change `List` copy constructor from implicit to explicit.
This commit is contained in:
Thaddeus Crews 2026-02-16 15:02:34 -06:00
commit 1e12317895
No known key found for this signature in database
GPG key ID: 8C6E5FEB5FC03CCC
20 changed files with 29 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

2
core/config/project_settings.h
View file

@ -204,7 +204,7 @@ public:
const HashMap<StringName, PropertyInfo> &get_custom_property_info() const;
uint64_t get_last_saved_time() { return last_save_time; }
List<String> get_input_presets() const { return input_presets; }
List<String> get_input_presets() const { return List<String>(input_presets); }
Variant get_setting_with_override(const StringName &p_name) const;
Variant get_setting_with_override_and_custom_features(const StringName &p_name, const Vector<String> &p_features) const;

2
core/extension/gdextension.cpp
View file

@ -950,7 +950,7 @@ void GDExtension::prepare_reload() {
state.push_back(Pair<String, Variant>(P.name, value));
}
E.value.instance_state[obj_id] = {
state, // List<Pair<String, Variant>> properties;
std::move(state), // List<Pair<String, Variant>> properties;
obj->is_extension_placeholder(), // bool is_placeholder;
};
}

4
core/io/ip.cpp
View file

@ -205,7 +205,7 @@ IPAddress IP::get_resolve_item_address(ResolverID p_id) const {
return IPAddress();
}
List<IPAddress> res = resolver->queue[p_id].response;
List<IPAddress> res(resolver->queue[p_id].response);
for (const IPAddress &E : res) {
if (E.is_valid()) {
@ -224,7 +224,7 @@ Array IP::get_resolve_item_addresses(ResolverID p_id) const {
return Array();
}
List<IPAddress> res = resolver->queue[p_id].response;
List<IPAddress> res(resolver->queue[p_id].response);
Array result;
for (const IPAddress &E : res) {

2
core/os/os.cpp
View file

@ -654,7 +654,7 @@ bool OS::is_restart_on_exit_set() const {
}
List<String> OS::get_restart_on_exit_arguments() const {
return restart_commandline;
return List<String>(restart_commandline);
}
PackedStringArray OS::get_connected_midi_inputs() {

4
core/os/os.h
View file

@ -235,8 +235,8 @@ public:
virtual String get_distribution_name() const = 0;
virtual String get_version() const = 0;
virtual String get_version_alias() const { return get_version(); }
virtual List<String> get_cmdline_args() const { return _cmdline; }
virtual List<String> get_cmdline_user_args() const { return _user_args; }
virtual List<String> get_cmdline_args() const { return List<String>(_cmdline); }
virtual List<String> get_cmdline_user_args() const { return List<String>(_user_args); }
virtual List<String> get_cmdline_platform_args() const { return List<String>(); }
virtual String get_model_name() const;

5
core/templates/list.h
View file

@ -685,10 +685,7 @@ public:
return (void *)_data;
}
/**
* copy constructor for the list
*/
List(const List &p_list) {
explicit List(const List &p_list) {
const Element *it = p_list.front();
while (it) {
push_back(it->get());

2
editor/docks/scene_tree_dock.cpp
View file

@ -4465,7 +4465,7 @@ List<Node *> SceneTreeDock::paste_nodes(bool p_paste_as_sibling) {
}
List<Node *> SceneTreeDock::get_node_clipboard() const {
return node_clipboard;
return List<Node *>(node_clipboard);
}
void SceneTreeDock::add_remote_tree_editor(Tree *p_remote) {

2
editor/editor_node.cpp
View file

@ -1945,7 +1945,7 @@ int EditorNode::get_resource_count(Ref<Resource> p_res) {
List<Node *> EditorNode::get_resource_node_list(Ref<Resource> p_res) {
List<Node *> *L = resource_count.getptr(p_res);
return L == nullptr ? List<Node *>() : *L;
return L == nullptr ? List<Node *>() : List<Node *>(*L);
}
void EditorNode::update_node_reference(const Variant &p_value, Node *p_node, bool p_remove) {

2
editor/export/editor_export.cpp
View file

@ -482,7 +482,7 @@ void EditorExport::update_export_presets() {
export_presets_updated = true;
bool update_value_overrides = false;
List<EditorExportPlatform::ExportOption> options = platform_options[preset->get_platform()->get_name()];
List<EditorExportPlatform::ExportOption> options(platform_options[preset->get_platform()->get_name()]);
// Clear the preset properties prior to reloading, keep the values to preserve options from plugins that may be currently disabled.
preset->properties.clear();

2
editor/file_system/dependency_editor.cpp
View file

@ -239,7 +239,7 @@ List<String> DependencyEditor::_filter_deps(const List<String> &p_deps) {
const String filter_text = filter->get_text();
if (filter_text.is_empty()) {
return p_deps;
return List<String>(p_deps);
}
List<String> filtered;

4
editor/scene/canvas_item_editor_plugin.cpp
View file

@ -360,7 +360,7 @@ void CanvasItemEditor::_snap_other_nodes(
}
}
for (int i = 0; i < p_current->get_child_count(); i++) {
_snap_other_nodes(p_value, p_transform_to_snap, r_current_snap, r_current_snap_target, p_snap_target, p_exceptions, p_current->get_child(i));
_snap_other_nodes(p_value, p_transform_to_snap, r_current_snap, r_current_snap_target, p_snap_target, List<const CanvasItem *>(p_exceptions), p_current->get_child(i));
}
}
@ -447,7 +447,7 @@ Point2 CanvasItemEditor::snap_point(Point2 p_target, unsigned int p_modes, unsig
p_target, to_snap_transform,
output, snap_target,
SNAP_TARGET_OTHER_NODE,
exceptions,
List<const CanvasItem *>(exceptions),
get_tree()->get_edited_scene_root());
}

4
editor/settings/editor_settings.cpp
View file

@ -203,7 +203,7 @@ bool EditorSettings::_get(const StringName &p_name, Variant &r_ret) const {
continue;
}
List<Ref<InputEvent>> events = action_override.value;
List<Ref<InputEvent>> events(action_override.value);
Dictionary action_dict;
action_dict["name"] = action_override.key;
@ -2210,7 +2210,7 @@ const Array EditorSettings::get_builtin_action_overrides(const String &p_name) c
if (AO) {
Array event_array;
List<Ref<InputEvent>> events_list = AO->value;
List<Ref<InputEvent>> events_list(AO->value);
for (const Ref<InputEvent> &E : events_list) {
event_array.push_back(E);
}

4
editor/settings/editor_settings_dialog.cpp
View file

@ -362,7 +362,7 @@ bool EditorSettingsDialog::_is_in_project_manager() const {
void EditorSettingsDialog::_update_builtin_action(const String &p_name, const Array &p_events) {
Array old_input_array = EditorSettings::get_singleton()->get_builtin_action_overrides(p_name);
if (old_input_array.is_empty()) {
List<Ref<InputEvent>> defaults = InputMap::get_singleton()->get_builtins_with_feature_overrides_applied()[current_edited_identifier];
List<Ref<InputEvent>> defaults(InputMap::get_singleton()->get_builtins_with_feature_overrides_applied()[current_edited_identifier]);
old_input_array = _event_list_to_array_helper(defaults);
}
@ -743,7 +743,7 @@ void EditorSettingsDialog::_shortcut_button_pressed(Object *p_item, int p_column
case EditorSettingsDialog::SHORTCUT_REVERT: {
// Only for "shortcut" types
if (is_editing_action) {
List<Ref<InputEvent>> defaults = InputMap::get_singleton()->get_builtins_with_feature_overrides_applied()[current_edited_identifier];
List<Ref<InputEvent>> defaults(InputMap::get_singleton()->get_builtins_with_feature_overrides_applied()[current_edited_identifier]);
Array events = _event_list_to_array_helper(defaults);
_update_builtin_action(current_edited_identifier, events);

2
editor/shader/shader_create_dialog.cpp
View file

@ -265,7 +265,7 @@ void ShaderCreateDialog::_browse_path() {
file_browse->set_customization_flag_enabled(FileDialog::CUSTOMIZATION_OVERWRITE_WARNING, false);
file_browse->clear_filters();
List<String> extensions = type_data.get(type_menu->get_selected()).extensions;
List<String> extensions(type_data.get(type_menu->get_selected()).extensions);
for (const String &E : extensions) {
file_browse->add_filter("*." + E);

2
modules/gdscript/gdscript_analyzer.cpp
View file

@ -6533,7 +6533,7 @@ void GDScriptAnalyzer::resolve_pending_lambda_bodies() {
GDScriptParser::LambdaNode *previous_lambda = current_lambda;
bool previous_static_context = static_context;
List<GDScriptParser::LambdaNode *> lambdas = pending_body_resolution_lambdas;
List<GDScriptParser::LambdaNode *> lambdas = std::move(pending_body_resolution_lambdas);
pending_body_resolution_lambdas.clear();
for (GDScriptParser::LambdaNode *lambda : lambdas) {

4
modules/multiplayer/multiplayer_synchronizer.cpp
View file

@ -372,7 +372,7 @@ void MultiplayerSynchronizer::set_multiplayer_authority(int p_peer_id, bool p_re
Error MultiplayerSynchronizer::_watch_changes(uint64_t p_usec) {
ERR_FAIL_COND_V(replication_config.is_null(), FAILED);
const List<NodePath> props = replication_config->get_watch_properties();
const List<NodePath> props(replication_config->get_watch_properties());
if (props.size() != watchers.size()) {
watchers.resize(props.size());
}
@ -436,7 +436,7 @@ List<Variant> MultiplayerSynchronizer::get_delta_state(uint64_t p_cur_usec, uint
List<NodePath> MultiplayerSynchronizer::get_delta_properties(uint64_t p_indexes) {
List<NodePath> out;
ERR_FAIL_COND_V(replication_config.is_null(), out);
const List<NodePath> watch_props = replication_config->get_watch_properties();
const List<NodePath> watch_props(replication_config->get_watch_properties());
int idx = 0;
for (const NodePath &prop : watch_props) {
if ((p_indexes & (1ULL << idx++)) == 0) {

6
modules/multiplayer/scene_replication_interface.cpp
View file

@ -249,7 +249,7 @@ Error SceneReplicationInterface::on_replication_start(Object *p_obj, Variant p_c
if (pending_buffer_size > 0) {
ERR_FAIL_COND_V(!node || !sync->get_replication_config_ptr(), ERR_UNCONFIGURED);
int consumed = 0;
const List<NodePath> props = sync->get_replication_config_ptr()->get_spawn_properties();
const List<NodePath> props(sync->get_replication_config_ptr()->get_spawn_properties());
Vector<Variant> vars;
vars.resize(props.size());
Error err = MultiplayerAPI::decode_and_decompress_variants(vars, pending_buffer, pending_buffer_size, consumed);
@ -823,7 +823,7 @@ void SceneReplicationInterface::_send_sync(int p_peer, const HashSet<ObjectID> &
int size;
Vector<Variant> vars;
Vector<const Variant *> varp;
const List<NodePath> props = sync->get_replication_config_ptr()->get_sync_properties();
const List<NodePath> props(sync->get_replication_config_ptr()->get_sync_properties());
Error err = MultiplayerSynchronizer::get_state(props, node, vars, varp);
ERR_CONTINUE_MSG(err != OK, "Unable to retrieve sync state.");
err = MultiplayerAPI::encode_and_compress_variants(varp.ptrw(), varp.size(), nullptr, size);
@ -882,7 +882,7 @@ Error SceneReplicationInterface::on_sync_receive(int p_from, const uint8_t *p_bu
ofs += size;
continue;
}
const List<NodePath> props = sync->get_replication_config_ptr()->get_sync_properties();
const List<NodePath> props(sync->get_replication_config_ptr()->get_sync_properties());
Vector<Variant> vars;
vars.resize(props.size());
int consumed;

4
platform/macos/os_macos.mm
View file

@ -274,7 +274,7 @@ void OS_MacOS::set_cmdline_platform_args(const List<String> &p_args) {
}
List<String> OS_MacOS::get_cmdline_platform_args() const {
return launch_service_args;
return List<String>(launch_service_args);
}
void OS_MacOS::load_shell_environment() const {
@ -874,7 +874,7 @@ Error OS_MacOS::create_instance(const List<String> &p_arguments, ProcessID *r_ch
// Project started from the editor, inject "path" argument to set instance working directory.
char cwd[PATH_MAX];
if (::getcwd(cwd, sizeof(cwd)) != nullptr) {
List<String> arguments = p_arguments;
List<String> arguments(p_arguments);
arguments.push_back("--path");
arguments.push_back(String::utf8(cwd));
return create_process(path, arguments, r_child_id, false);

2
scene/gui/graph_edit.cpp
View file

@ -2590,7 +2590,7 @@ TypedArray<Dictionary> GraphEdit::_get_connections_intersecting_with_rect(const
TypedArray<Dictionary> GraphEdit::_get_connection_list_from_node(const StringName &p_node) const {
ERR_FAIL_COND_V(!connection_map.has(p_node), TypedArray<Dictionary>());
List<Ref<GraphEdit::Connection>> connections_from_node = connection_map.get(p_node);
List<Ref<GraphEdit::Connection>> connections_from_node(connection_map.get(p_node));
TypedArray<Dictionary> connections_from_node_dict;
for (const Ref<Connection> &conn : connections_from_node) {

2
scene/main/node.cpp
View file

@ -3211,7 +3211,7 @@ void Node::replace_by(RequiredParam<Node> rp_node, bool p_keep_groups) {
EXTRACT_PARAM_OR_FAIL(p_node, rp_node);
ERR_FAIL_COND(p_node->data.parent);
List<Node *> owned = data.owned;
List<Node *> owned(data.owned);
List<Node *> owned_by_owner;
Node *owner = (data.owner == this) ? p_node : data.owner;