Sara/behaviour-tree-test
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

Disable multi-window buttons instead of hiding them when support is unavailable

Browse source 
This is more explicit as for why this functionality isn't available
depending on editor settings and current platform.

This also exposes a `EditorInterface.is_multi_window_enabled()` method
so that editor plugins can easily query whether the editor is able and
expected to create multiple windows.
This commit is contained in:
Hugo Locurcio 2023-11-06 12:41:08 +01:00
parent 17e7f85c06
commit 04a930d9a6
No known key found for this signature in database
GPG key ID: 39E8F8BE30B0A49C
10 changed files with 81 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

14
editor/window_wrapper.cpp
View file

@ -315,7 +315,7 @@ void WindowWrapper::set_margins_enabled(bool p_enabled) {
}
WindowWrapper::WindowWrapper() {
if (SceneTree::get_singleton()->get_root()->is_embedding_subwindows() || EDITOR_GET("interface/editor/single_window_mode") || !EDITOR_GET("interface/multi_window/enable")) {
if (!EditorNode::get_singleton()->is_multi_window_enabled()) {
return;
}
@ -375,7 +375,9 @@ void ScreenSelect::_build_advanced_menu() {
}
void ScreenSelect::_emit_screen_signal(int p_screen_idx) {
emit_signal("request_open_in_screen", p_screen_idx);
if (!is_disabled()) {
emit_signal("request_open_in_screen", p_screen_idx);
}
}
void ScreenSelect::_bind_methods() {
@ -436,13 +438,19 @@ void ScreenSelect::pressed() {
}
ScreenSelect::ScreenSelect() {
set_tooltip_text(TTR("Make this panel floating.\nRight click to open the screen selector."));
set_button_mask(MouseButtonMask::RIGHT);
set_flat(true);
set_toggle_mode(true);
set_focus_mode(FOCUS_NONE);
set_action_mode(ACTION_MODE_BUTTON_PRESS);
if (!EditorNode::get_singleton()->is_multi_window_enabled()) {
set_disabled(true);
set_tooltip_text(EditorNode::get_singleton()->get_multiwindow_support_tooltip_text());
} else {
set_tooltip_text(TTR("Make this panel floating.\nRight-click to open the screen selector."));
}
// Create the popup.
const Size2 borders = Size2(4, 4) * EDSCALE;