mirror of
				https://github.com/nicbarker/clay.git
				synced 2025-11-04 08:36:17 +00:00 
			
		
		
		
	[Core] Apply minimum width for single words and fix some minimum sizing bugs
This commit is contained in:
		
							parent
							
								
									61490e4557
								
							
						
					
					
						commit
						ad49977f1b
					
				
										
											Binary file not shown.
										
									
								
							
										
											Binary file not shown.
										
									
								
							
										
											Binary file not shown.
										
									
								
							
										
											Binary file not shown.
										
									
								
							
										
											Binary file not shown.
										
									
								
							
							
								
								
									
										30
									
								
								clay.h
									
									
									
									
									
								
							
							
						
						
									
										30
									
								
								clay.h
									
									
									
									
									
								
							| 
						 | 
				
			
			@ -1156,6 +1156,7 @@ CLAY__ARRAY_DEFINE(Clay__MeasuredWord, Clay__MeasuredWordArray)
 | 
			
		|||
typedef struct {
 | 
			
		||||
    Clay_Dimensions unwrappedDimensions;
 | 
			
		||||
    int32_t measuredWordsStartIndex;
 | 
			
		||||
    float minWidth;
 | 
			
		||||
    bool containsNewlines;
 | 
			
		||||
    // Hash map data
 | 
			
		||||
    uint32_t id;
 | 
			
		||||
| 
						 | 
				
			
			@ -1504,6 +1505,7 @@ Clay__MeasureTextCacheItem *Clay__MeasureTextCached(Clay_String *text, Clay_Text
 | 
			
		|||
        if (current == ' ' || current == '\n') {
 | 
			
		||||
            int32_t length = end - start;
 | 
			
		||||
            Clay_Dimensions dimensions = Clay__MeasureText(CLAY__INIT(Clay_StringSlice) { .length = length, .chars = &text->chars[start], .baseChars = text->chars }, config, context->measureTextUserData);
 | 
			
		||||
            measured->minWidth = CLAY__MAX(dimensions.width, measured->minWidth);
 | 
			
		||||
            measuredHeight = CLAY__MAX(measuredHeight, dimensions.height);
 | 
			
		||||
            if (current == ' ') {
 | 
			
		||||
                dimensions.width += spaceWidth;
 | 
			
		||||
| 
						 | 
				
			
			@ -1529,6 +1531,7 @@ Clay__MeasureTextCacheItem *Clay__MeasureTextCached(Clay_String *text, Clay_Text
 | 
			
		|||
        Clay__AddMeasuredWord(CLAY__INIT(Clay__MeasuredWord) { .startOffset = start, .length = end - start, .width = dimensions.width, .next = -1 }, previousWord);
 | 
			
		||||
        lineWidth += dimensions.width;
 | 
			
		||||
        measuredHeight = CLAY__MAX(measuredHeight, dimensions.height);
 | 
			
		||||
        measured->minWidth = CLAY__MAX(dimensions.width, measured->minWidth);
 | 
			
		||||
    }
 | 
			
		||||
    measuredWidth = CLAY__MAX(lineWidth, measuredWidth);
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			@ -1663,21 +1666,25 @@ void Clay__CloseElement(void) {
 | 
			
		|||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    float leftRightPadding = (float)(layoutConfig->padding.left + layoutConfig->padding.right);
 | 
			
		||||
    float topBottomPadding = (float)(layoutConfig->padding.top + layoutConfig->padding.bottom);
 | 
			
		||||
 | 
			
		||||
    // Attach children to the current open element
 | 
			
		||||
    openLayoutElement->childrenOrTextContent.children.elements = &context->layoutElementChildren.internalArray[context->layoutElementChildren.length];
 | 
			
		||||
    if (layoutConfig->layoutDirection == CLAY_LEFT_TO_RIGHT) {
 | 
			
		||||
        openLayoutElement->dimensions.width = (float)(layoutConfig->padding.left + layoutConfig->padding.right);
 | 
			
		||||
        openLayoutElement->dimensions.width = leftRightPadding;
 | 
			
		||||
        openLayoutElement->minDimensions.width = leftRightPadding;
 | 
			
		||||
        for (int32_t i = 0; i < openLayoutElement->childrenOrTextContent.children.length; i++) {
 | 
			
		||||
            int32_t childIndex = Clay__int32_tArray_GetValue(&context->layoutElementChildrenBuffer, (int)context->layoutElementChildrenBuffer.length - openLayoutElement->childrenOrTextContent.children.length + i);
 | 
			
		||||
            Clay_LayoutElement *child = Clay_LayoutElementArray_Get(&context->layoutElements, childIndex);
 | 
			
		||||
            openLayoutElement->dimensions.width += child->dimensions.width;
 | 
			
		||||
            openLayoutElement->dimensions.height = CLAY__MAX(openLayoutElement->dimensions.height, child->dimensions.height + layoutConfig->padding.top + layoutConfig->padding.bottom);
 | 
			
		||||
            openLayoutElement->dimensions.height = CLAY__MAX(openLayoutElement->dimensions.height, child->dimensions.height + topBottomPadding);
 | 
			
		||||
            // Minimum size of child elements doesn't matter to scroll containers as they can shrink and hide their contents
 | 
			
		||||
            if (!elementHasScrollHorizontal) {
 | 
			
		||||
                openLayoutElement->minDimensions.width += child->minDimensions.width;
 | 
			
		||||
            }
 | 
			
		||||
            if (!elementHasScrollVertical) {
 | 
			
		||||
                openLayoutElement->minDimensions.height = CLAY__MAX(openLayoutElement->minDimensions.height, child->minDimensions.height + layoutConfig->padding.top + layoutConfig->padding.bottom);
 | 
			
		||||
                openLayoutElement->minDimensions.height = CLAY__MAX(openLayoutElement->minDimensions.height, child->minDimensions.height + topBottomPadding);
 | 
			
		||||
            }
 | 
			
		||||
            Clay__int32_tArray_Add(&context->layoutElementChildren, childIndex);
 | 
			
		||||
        }
 | 
			
		||||
| 
						 | 
				
			
			@ -1686,18 +1693,19 @@ void Clay__CloseElement(void) {
 | 
			
		|||
        openLayoutElement->minDimensions.width += childGap;
 | 
			
		||||
    }
 | 
			
		||||
    else if (layoutConfig->layoutDirection == CLAY_TOP_TO_BOTTOM) {
 | 
			
		||||
        openLayoutElement->dimensions.height = (float)(layoutConfig->padding.top + layoutConfig->padding.bottom);
 | 
			
		||||
        openLayoutElement->dimensions.height = topBottomPadding;
 | 
			
		||||
        openLayoutElement->minDimensions.height = topBottomPadding;
 | 
			
		||||
        for (int32_t i = 0; i < openLayoutElement->childrenOrTextContent.children.length; i++) {
 | 
			
		||||
            int32_t childIndex = Clay__int32_tArray_GetValue(&context->layoutElementChildrenBuffer, (int)context->layoutElementChildrenBuffer.length - openLayoutElement->childrenOrTextContent.children.length + i);
 | 
			
		||||
            Clay_LayoutElement *child = Clay_LayoutElementArray_Get(&context->layoutElements, childIndex);
 | 
			
		||||
            openLayoutElement->dimensions.height += child->dimensions.height;
 | 
			
		||||
            openLayoutElement->dimensions.width = CLAY__MAX(openLayoutElement->dimensions.width, child->dimensions.width + layoutConfig->padding.left + layoutConfig->padding.right);
 | 
			
		||||
            openLayoutElement->dimensions.width = CLAY__MAX(openLayoutElement->dimensions.width, child->dimensions.width + leftRightPadding);
 | 
			
		||||
            // Minimum size of child elements doesn't matter to scroll containers as they can shrink and hide their contents
 | 
			
		||||
            if (!elementHasScrollVertical) {
 | 
			
		||||
                openLayoutElement->minDimensions.height += child->minDimensions.height;
 | 
			
		||||
            }
 | 
			
		||||
            if (!elementHasScrollHorizontal) {
 | 
			
		||||
                openLayoutElement->minDimensions.width = CLAY__MAX(openLayoutElement->minDimensions.width, child->minDimensions.width + layoutConfig->padding.left + layoutConfig->padding.right);
 | 
			
		||||
                openLayoutElement->minDimensions.width = CLAY__MAX(openLayoutElement->minDimensions.width, child->minDimensions.width + leftRightPadding);
 | 
			
		||||
            }
 | 
			
		||||
            Clay__int32_tArray_Add(&context->layoutElementChildren, childIndex);
 | 
			
		||||
        }
 | 
			
		||||
| 
						 | 
				
			
			@ -1849,7 +1857,7 @@ void Clay__OpenTextElement(Clay_String text, Clay_TextElementConfig *textConfig)
 | 
			
		|||
    Clay__StringArray_Add(&context->layoutElementIdStrings, elementId.stringId);
 | 
			
		||||
    Clay_Dimensions textDimensions = { .width = textMeasured->unwrappedDimensions.width, .height = textConfig->lineHeight > 0 ? (float)textConfig->lineHeight : textMeasured->unwrappedDimensions.height };
 | 
			
		||||
    textElement->dimensions = textDimensions;
 | 
			
		||||
    textElement->minDimensions = CLAY__INIT(Clay_Dimensions) { .width = textMeasured->unwrappedDimensions.height, .height = textDimensions.height }; // TODO not sure this is the best way to decide min width for text
 | 
			
		||||
    textElement->minDimensions = CLAY__INIT(Clay_Dimensions) { .width = textMeasured->minWidth, .height = textDimensions.height };
 | 
			
		||||
    textElement->childrenOrTextContent.textElementData = Clay__TextElementDataArray_Add(&context->textElementData, CLAY__INIT(Clay__TextElementData) { .text = text, .preferredDimensions = textMeasured->unwrappedDimensions, .elementIndex = context->layoutElements.length - 1 });
 | 
			
		||||
    textElement->elementConfigs = CLAY__INIT(Clay__ElementConfigArraySlice) {
 | 
			
		||||
            .length = 1,
 | 
			
		||||
| 
						 | 
				
			
			@ -2237,25 +2245,25 @@ void Clay__SizeContainersAlongAxis(bool xAxis) {
 | 
			
		|||
                for (int32_t childOffset = 0; childOffset < resizableContainerBuffer.length; childOffset++) {
 | 
			
		||||
                    Clay_LayoutElement *childElement = Clay_LayoutElementArray_Get(&context->layoutElements, Clay__int32_tArray_GetValue(&resizableContainerBuffer, childOffset));
 | 
			
		||||
                    Clay_SizingAxis childSizing = xAxis ? childElement->layoutConfig->sizing.width : childElement->layoutConfig->sizing.height;
 | 
			
		||||
                    float minSize = xAxis ? childElement->minDimensions.width : childElement->minDimensions.height;
 | 
			
		||||
                    float *childSize = xAxis ? &childElement->dimensions.width : &childElement->dimensions.height;
 | 
			
		||||
 | 
			
		||||
                    if (!xAxis && Clay__ElementHasConfig(childElement, CLAY__ELEMENT_CONFIG_TYPE_IMAGE)) {
 | 
			
		||||
                        continue; // Currently we don't support resizing aspect ratio images on the Y axis because it would break the ratio
 | 
			
		||||
                    }
 | 
			
		||||
 | 
			
		||||
                    // If we're laying out the children of a scroll panel, grow containers expand to the height of the inner content, not the outer container
 | 
			
		||||
                    float maxSize = parentSize - parentPadding;
 | 
			
		||||
                    // If we're laying out the children of a scroll panel, grow containers expand to the size of the inner content, not the outer container
 | 
			
		||||
                    if (Clay__ElementHasConfig(parent, CLAY__ELEMENT_CONFIG_TYPE_SCROLL)) {
 | 
			
		||||
                        Clay_ScrollElementConfig *scrollElementConfig = Clay__FindElementConfigWithType(parent, CLAY__ELEMENT_CONFIG_TYPE_SCROLL).scrollElementConfig;
 | 
			
		||||
                        if (((xAxis && scrollElementConfig->horizontal) || (!xAxis && scrollElementConfig->vertical))) {
 | 
			
		||||
                            maxSize = CLAY__MAX(maxSize, innerContentSize);
 | 
			
		||||
                        }
 | 
			
		||||
                    }
 | 
			
		||||
                    if (childSizing.type == CLAY__SIZING_TYPE_FIT) {
 | 
			
		||||
                        *childSize = CLAY__MAX(childSizing.size.minMax.min, CLAY__MIN(*childSize, maxSize));
 | 
			
		||||
                    } else if (childSizing.type == CLAY__SIZING_TYPE_GROW) {
 | 
			
		||||
                    if (childSizing.type == CLAY__SIZING_TYPE_GROW) {
 | 
			
		||||
                        *childSize = CLAY__MIN(maxSize, childSizing.size.minMax.max);
 | 
			
		||||
                    }
 | 
			
		||||
                    *childSize = CLAY__MAX(minSize, CLAY__MIN(*childSize, maxSize));
 | 
			
		||||
                }
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in a new issue